Date post: | 22-Feb-2017 |
Category: |
Software |
Upload: | paul-gower |
View: | 102 times |
Download: | 0 times |
Father of Code Review
http://ieeexplore.ieee.org/xpl/articleDetails.jsp?arnumber=5388086&filter%3DAND%28p_IS_Number%3A5388084%29
aka Fagan Inspections
Fagan Inspections
https://en.wikipedia.org/wiki/Fagan_inspection
Lightweight Code Reviews
https://en.wikipedia.org/wiki/Code_review
Reviewer: Focus on the code
Don’t say: “You didn’t name these variables well!”
Instead: “I don’t understand these variable names, can you help me understand them?”
“ “The objective is for everyone to find defects, including the author, not to
prove the work product has no defects. People exchange work products to review, with the expectation that as
authors, they will produce errors, and as reviewers, they will find errors.
Everyone ends up learning from their own mistakes and other people’s
mistakes.” – Jerry Weinberg, “The Psychology of
Computer Programming”, 1971
Less Than 60 Minutes
http://www.news.illinois.edu/news/11/0208focus_AlejandroLleras.html
Daily Code Review
http://blog.fogcreek.com/effective-code-reviews-9-tips-from-a-converted-skeptic/
Always Use A Checklist
http://www.codeproject.com/Articles/593751/Code-Review-Checklist-and-Guidelines-for-Csharp-De
“ “…the average defect detection rate is only 25 percent for unit testing, 35 percent for function testing, and 45 percent for integration testing.
In contrast, the average effectiveness of design and code
inspections are 55 and 60 percent.” - Steve McConnell, Code
Complete, 2004
“ “The aim is to catch what mistakes you can and to get better – not to attempt perfection.”
- Erik Dietrich, “Creating Your Code
Review Checklist”, 2015
Review
• No more than 60 mins • No more than 200 lines of code • Use Static Code Analysis • Use Check Lists • Use A Code Review Tool
THANK YOU!
@paulmgower
http://bit.ly/mcc2016-cr
lunamark.com