Review your code with Perforce and all your wildest dreams will … · 2009-05-13 · 1 Review your...

1

http://smartbear.com

Review your code with Perforce and all your wildest dreams

will come true

(vote for Pedro)


Jason Cohen

2



smartbear.com

3


Code Collaborator

codecollaborator.com


Peer Code Review +

Perforce

!=

Suck

4


Why review code?


Requirements

Design

Architecture

Discussion

Review

Review

5


Requirements

Design

Architecture

Code

Discussion

Review

Review

(void)0

Where most of the bugs come from


6


COUNT(editors) >

COUNT(writers)


9 errors/page

7


Spell Czech:

Good, butt knot enough


Find bugs

Train new hires

Cross-training

8


if ( youLikeItSoMuch() ) { marryIt(); }


1. Time

2. Busywork

9


Hapless Developer

Reviewers

Perforce


Peer Code Review +

Perforce

!=

Suck

10


Review Method #1:

Over-the-shoulder


Over-the-Shoulder

11


Over-the-Shoulder


Over-the-Shoulder

12


Walk through the diffs


Post-its: Airtight issue-tracking system

13


Over-the-Shoulder

Easy, Free

Interruption

No info

Walk-through


Review Method #2:

Meetings

14


Schedule it


Walk through the diffs

15


Print-outs are soooo 1976


Formal Inspections

Michael Fagan, IBM, 1976

16


1. Planning 2. Intro 3. Reading

4. Inspect 5. Rework 6. Verify

7. Complete 8. Improve

Fagan’s Phases

= Meeting


Meetings are required. —Michael Fagan, ‘76

17


Meetings are required. —Gilb, Fagan, Wiegers


You didn’t check for null. —The Phantom Inspector

18


Are meetings worth it? —Lawrence Votta, ‘93


4%

19


Review Method #3:

Email


Submit Changelist

20


Get Email notification


Look at diffs

21


Talk over email


Review Daemon

System Administrator’s Guide Chapter 6

(near the end)

Server-side Configuration

22


Reviews: //depot/main/... //depot/.../README //depot/jobs

Subscribe via User Spec (p4 user)


Python is just as scared of you as you are of it.

p4review.py

23


Email

Easy, Free

No interruption, remote

Conversation-tracking

No info / No end

“I thought you had it.”


Review Method #4:

Tool-Assisted

24


Tools

Code Collaborator Commercial

Crucible Commercial

Review Board Open-Source

Mondrian Internal


Alleged Benefits

Reality

Tools

25


Hapless Developer

Reviewers

Perforce

Identify Changes

Package/Deliver

Organize Communication

Track Defects Audit Trail

Reports Automatic Metrics


Best Practices How to not waste time

26


Cisco® MeetingPlace® Case Study

3,200,000 lines of code

2,500 reviews

50 developers

10 months

San Diego, Bangalore, Budapest


It’s in the handbook

27


60-90 minutes max

Time (minutes)

Def

ects

Fou

nd


When to review?

Pre-commit blocks development

Post-commit harder to fix bugs

Pre-commit is less workflow

Pre-commit protects others

28


Checklists


Checklist for Checklists

7 ± 2 (George Miller, ’52)

No obvious stuff

Nothing that can be automated

Stuff that’s easy to forget

EXAMPLE: Errors handled properly everywhere in method

29


(Re)building a checklist

The Week of Pain


Getting Started

30


Selected Code

Stable branch

Core module

Top 10 scariest files


Unit tests only

31


During feature-freeze


You know what to do, and you know when to do it.

<beeep!>

32


Gotta Wanna


Thank You.

Code Collaborator (product placement? you rogue!)

http://codecollab.com http://blog.smartbear.com Twitter: @smartbears

Jason Cohen [email protected] http://blog.asmartbear.com

Date post:	18-Jul-2020
Category:	Documents
Upload:	others
View:	5 times
Download:	0 times

Review your code with Perforce and all your wildest dreams will … · 2009-05-13 · 1 Review your...

Documents