Surviving Code ReviewsLorna Mitchell
ROME 18-19 MARCH 2016
Surviving Code ReviewsLorna Mitchell, CodeMotion Rome 2016
maintainer and team lead
unsolicited advice
If there aren't anyacceptance criteria for
your patch, invent some
git diff master
git diff master...HEAD
common code mistakes
exotic code, no comments
Committing commentedcode is like leaving litter
on a campsite
can you break your code?
Your commit history willbe part of my projectuntil the end of time
git reset --soft $(git merge-base master HEAD)
more info than diff
http://chris.beams.io/posts/git-commit/
git merge --no-commit --no-ff feature
git merge --abort
A pull request is the startof a conversation about a
feature
what will I observe?
"review" vs "merge"
peer review vs gatekeepers
Being able to see whatyou're NOT looking at isa reviewer's superpower
constructive feedback
colleagues vs contributors
too much feedback
sandwich technique
Pull requests have alifecycle, be prepared tochampion them to the
end
Thankyouhttp://lornajane.net
This work is licensed under a Creative Commons
Attribution-NonCommercial-ShareAlike 3.0Unported License.