+ All Categories
Home > Documents > webstore

webstore

Date post: 15-Jan-2016
Category:
Upload: fernando-jimenez
View: 226 times
Download: 0 times
Share this document with a friend
Description:
web
64
PayPhone WebStore 1.0 2015-05-07
Transcript
Page 1: webstore

PayPhone WebStore1.0

2015-05-07

Page 2: webstore

1. PayPhone WebStore Page 1

1.1. Dashboard1.2. Hotspots1.3. New issues in the last 30 days1.4. Violations details with priority up to info1.5. Most violated files by level with priority up to info1.6. Additional information

2. PayPhone.WebStore Page 32

2.1. Dashboard2.2. Hotspots2.3. New issues in the last 30 days2.4. Violations details with priority up to info2.5. Most violated files by level with priority up to info2.6. Additional information

PayPhone WebStore1.0

Page 3: webstore

1. PayPhone WebStoreThis chapter presents an overview of the project measures. This dashboard shows the most important measures

related to project quality, and it provides a good starting point for identifying problems in source code.

1.1. Dashboard

Lines of code75,294N/A packages69 classes22,055 methods9.6% duplicated lines

Comments28.5%30,032 comment lines

Complexity6.00.0 /class40,623 decision points

Code CoverageN/AN/A tests

Test SuccessN/AN/A failuresN/A errors

Technical Debt1.226d

Violations34,380

Blocker 35Critical 41Major 23,006Minor 10,748Info 550

LCOM4N/AN/A files having LCOM4>1

RFCN/A/class

Package tangleindexN/AN/A cycles

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 1

Page 4: webstore

1.2. Hotspots

1.3. New issues in the last 30 days

Most violated rulesTrailing commas should not be used 35 BLOCKERIdentical expressions should not be used onboth sides of a binary operator

25 CRITICAL

Switch cases should end with anunconditional "break" statement

10 CRITICAL

Relational operators should be used in "for"loop termination conditions

3 CRITICAL

"for" loop incrementers should modify thevariable being tested in the loop's stopcondition

2 CRITICAL

Most violated filesangular-google-maps.min.js 5,240angular.min.js 3,558jquery-2.1.3.min.js 2,451metro-bootstrap.css 2,241metro-bootstrap.min.css 2,233

Most complex filesangular.js 3,784angular.min.js 3,569angular-google-maps.min.js 3,389jquery-2.1.3.js 2,644jquery-2.1.3.min.js 2,561

Most duplicated filesui-bootstrap-tpls.js 4,199ui-bootstrap.js 3,890jquery-2.1.3.intellisense.js 2,554respond.matchmedia.addListener.js 227respond.js 222

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 2

Page 5: webstore

Rule Require compatible vendor prefixesMissing vendor: -moz for property: transform

File LineSite.css 192, 192, 159, 196, 165, 165,

125, 159, 196, 38, 159, 186,182, 182, 196, 186

Rule Expressions should not be too complexReduce the number of conditional operators (7) used in the expression (maximum allowed3).

File LineModelDescriptionGenerator.cs 244HelpPageSampleGenerator.cs 423HelpPageSampleKey.cs 141ObjectGenerator.cs 189

Rule Disallow overqualified elementsDisallow overqualified elements

File LineHelpPage.css 14, 125Site.css 89, 118, 143

Rule Disallow !importantDisallow !important

File LineSite.css 39, 212, 40, 41, 233, 229,

218, 213

Rule Disallow empty rulesEmpty rule

File LineSite.css 61

Rule Exceptions should not be ignoredHandle the exception, rather than swallow it with an empty statement.

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 3

Page 6: webstore

File LineHelpPageSampleGenerator.cs 200

Rule Method parameters and caught exceptions should not be reassignedIntroduce a new variable instead of reusing the parameter "modelType".

File LineModelDescriptionGenerator.cs 120

Rule Disallow overspecified selectorsDisallow overspecified selectors

File LineHelpPage.css 58Site.css 217

Rule Methods should not be too complexThe Cyclomatic Complexity of this method is 27 which is greater than 10 authorized).

File LineModelDescriptionGenerator.cs 110ObjectGenerator.cs 104, 38

Rule Require standard property with vendor prefixNo standard property defined after

File LineSite.css 166, 197, 40, 187, 41, 193,

132, 131, 183

Rule Disallow units for zero valuesDisallow zero values with units

File LineHelpPage.css 33, 73, 73, 33, 52, 73, 82, 53,

33, 82, 82Site.css 109, 110, 110

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 4

Page 7: webstore

1.4. Violations details with priority up to info

BLOCKER violations

Rule Sections of code should not be "commented out"Remove this commented out code.

File LineBundleConfig.cs 24Startup.Auth.cs 87, 83, 90, 93, 79HelpPageConfig.cs 76, 64, 68, 72, 43, 45, 37, 80HelpPageConfigurationExtensions.cs 287, 275, 277XmlDocumentationProvider.cs 142

Rule Disallow IDs in selectorsDisallow IDs in selectors

File LineHelpPage.css 7, 125Site.css 136, 46, 100, 93, 89, 125, 61,

73, 52, 126, 143

Rule "switch" statements should end with a "default" clauseAdd a "default" clause to this switch statement.

File LineHelpPageSampleGenerator.cs 407

Rule Beware of box model sizePossible box sizing issue

File LineSite.css 109

Rule Lines should not be too longSplit this 217 characters long line (which is greater than 200 authorized).

File LineHelpPageSampleGenerator.cs 234, 149ObjectGenerator.cs 28

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 5

Page 8: webstore

CRITICAL violations

Rule Trailing commas should not be usedAvoid trailing comma in array and object literals.

File LineRegisterController.js 179StoreRoutes.js 197, 141, 147, 127, 211, 111,

169, 26, 161, 155, 175, 203,41, 73, 189, 133, 183, 57

LoginService.js 53, 16RegisterService.js 138, 27, 45, 78StoreService.js 41, 60UserStoreService.js 62, 97jquery-2.1.3.intellisense.js 2640, 496, 426, 1, 635, 711

Rule Identical expressions should not be used on both sides of a binaryoperator

Identical sub-expressions on both sides of operator "/"

File Lineangular-google-maps.min.js 9, 9angular.js 19977angular.min.js 155jquery-2.1.3.min.js 3lodash.js 1643, 2905, 2865, 3875,

2758, 5036, 4221, 2451,4162, 4062, 5177, 2512,2451, 2512, 297, 1643, 4409,296, 3876, 1878

Rule Switch cases should end with an unconditional "break" statementLast statement in this switch-clause should be an unconditional break.

File Lineangular-resource.js 481, 476angular-resource.min.js 7, 7angular.js 16774angular.min.js 141knockout-3.3.0.debug.js 1577, 1569knockout-3.3.0.js 42, 42

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 6

Page 9: webstore

MAJOR violations

Rule Relational operators should be used in "for" loop termination conditionsReplace '!=' operator with one of '<=', '>=', '<', or '>' comparison operators.

File Lineangular.min.js 19jquery-2.1.3.min.js 3, 3

Rule "for" loop incrementers should modify the variable being tested in theloop's stop condition

This loop's stop condition tests "element.length" but the incrementer updates "i".

File Lineangular.js 12489angular.min.js 103

Rule Local variables should not shadow "undefined"Rename this variable.

File Linelodash.js 13

Rule Assignments should not be made from within sub-expressionsExtract the assignment out of this expression.

File LineChart.js 546, 588, 644, 585, 592, 556,

605, 658, 550, 536, 645, 640,645, 632, 631, 560, 636, 540,478, 553, 656, 654

Chart.min.js 10, 10, 10, 10, 10, 10, 10, 11,10, 10, 10, 10, 10, 10, 10, 10,10, 11, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 11, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 11, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 11, 10,11, 10, 11, 11, 10, 10, 10, 10,10, 10, 10, 10, 10, 10

Rule Comma operator should not be used

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 7

Page 10: webstore

Remove use of this comma operator.

File LineChart.min.js 11, 10, 10, 10, 11, 11, 10, 10,

10, 10, 10, 10, 11, 10, 11, 11,11, 10, 10, 10, 10, 10, 11, 10,10, 10, 10, 10, 10, 10, 10, 11,10, 11, 10, 11, 11, 10, 10, 10,11, 10, 10, 11, 10, 10, 10, 10,10, 11, 10, 10, 11, 10, 10, 10,11, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 11, 10, 11,10, 10, 10, 10, 11, 10, 10, 10,11, 10, 10, 10, 10, 10, 11, 10,10, 10, 10, 10, 10, 11, 10, 10,11, 10, 10, 10

Rule Control structures should always use curly bracesMissing curly brace.

File LineChart.js 611, 539, 529, 644, 600, 599,

598, 912, 237, 631, 303, 613,580, 549, 213, 630, 624, 625,3010, 612, 2412, 750, 2665,591, 578, 626, 579, 220, 288,559, 584, 617, 662, 604

Chart.min.js 10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 11,10, 10, 11, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10

angular-animate.js 1219, 1553, 497, 718, 1218angular-animate.min.js 26, 28, 20, 16, 16, 31, 14, 16,

16, 19, 15, 13, 14, 9, 21, 14,25, 28, 17, 24, 14, 28, 31, 13,6

Rule Disallow !importantDisallow !important

File LineSite.css 39, 212, 40, 41, 233, 229,

218, 213

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 8

Page 11: webstore

bootstrap.css 243, 6504, 6369, 6556, 6429,199, 6405, 6495, 6449, 6560,6568, 197, 6409, 6356, 6435,6347, 6572, 6353, 6465, 250,4108, 6419, 256, 6499, 6399,6519, 6548, 6484, 4106,6424, 4388, 6469, 6474, 260,6350, 6538, 4391, 200, 198,6576, 6581, 6534, 4105,6509, 6439, 6395, 264, 6454,6524, 6444, 6381, 6489,6514, 6414, 230, 6459, 6479,6564, 6552, 196, 6529, 6542

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5

Rule Disallow overspecified selectorsDisallow overspecified selectors

File LineHelpPage.css 58Site.css 217bootstrap-theme.css 264, 240, 287, 265, 286, 241,

276, 285bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5bootstrap.css 2418, 4462, 5436, 2456,

2385, 2395, 2338, 4416,2263, 2432, 4249, 2453,2474, 2475, 5501, 4463,5535, 5456, 5507, 2374,4525, 2336, 5390, 2433,2297, 4524, 5411, 2354,5618, 4457, 2392, 5440,4447, 2359, 5466, 2390,5643, 2350, 5494, 5414,2454, 2339, 2343, 5480,2294, 5445, 5498, 2347,2295, 2293, 5582, 5478,2399, 2384, 2332, 5410,2341, 5433, 4464, 2412,2424, 2402, 5402, 2382,4517, 2279, 2265, 2471,2307, 2346, 5464, 2361,2280, 2348, 2312, 4458,4470, 4518, 5465, 4417,4566, 4512

Rule "===" and "!==" should be used instead of "==" and "!="Replace "==" with "===".

File Line

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 9

Page 12: webstore

Chart.js 612, 625, 305, 303, 599Chart.min.js 10, 10, 10, 10, 10, 10, 10, 10angular-animate.js 693, 1706, 1371, 663, 1357,

1338, 1355, 1827, 480, 1323,1415, 665, 588, 664, 1487,1357, 1333, 593, 465, 661

angular-animate.min.js 15, 9, 14, 14, 8, 25, 14, 11,14, 9, 13, 14, 6, 11, 7, 11, 22,11, 13, 14

angular-block-ui.js 344angular-block-ui.min.js 6angular-breadcrumb.min.js 4angular-chart.min.js 1, 1, 1, 1, 1, 1, 1, 1angular-cookies.js 62angular-cookies.min.js 6angular-file-upload-shim.js 241, 15, 110, 114angular-file-upload-shim.min.js 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,

2angular-file-upload.js 397, 388, 420, 222, 572, 397,

451, 340, 522angular-file-upload.min.js 2, 2, 2, 2, 2, 2, 2, 2

Rule Functions should not be too complexFunction has a complexity of 12 which is greater than 10 authorized.

File LineChart.js 1756, 383, 1884, 910Chart.min.js 10, 10, 10, 10angular-animate.js 1824, 1151, 1539, 1761,

1282, 632angular-animate.min.js 23, 16, 12, 19, 9, 25angular-breadcrumb.js 56angular-breadcrumb.min.js 4angular-chart.js 108angular-file-upload-shim.js 102angular-file-upload-shim.min.js 2angular-file-upload.js 124, 409, 232, 391angular-file-upload.min.js 2, 2, 2, 2angular-google-maps.min.js 6, 6, 6, 10, 9, 6, 5, 5, 10, 5, 8,

5, 8, 10, 7, 10, 9, 9, 6, 9, 8, 9,9, 10, 6, 10, 5, 10, 6, 9, 9, 7,5, 9, 8, 9, 9, 8

angular-loading-bar.js 74, 254angular-loading-bar.min.js 7angular-mocks.js 1553, 1533, 1111angular-resource.js 471angular-resource.min.js 7, 6

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 10

Page 13: webstore

angular-route.js 487angular-route.min.js 9angular-store.js 156, 281, 324, 119angular-ui-router.js 1985, 738, 384, 2286, 3351,

84, 2091, 1593, 2171, 902,3048, 3164, 992, 2236

Rule Expressions should not be too complexReduce the number of conditional operators (5) used in the expression (maximum allowed3).

File LineChart.js 678, 1554, 668Chart.min.js 10, 10, 10, 10, 10, 10, 10angular-animate.js 1413angular-animate.min.js 29, 8, 15, 14, 26angular-block-ui.min.js 6, 6angular-breadcrumb.min.js 4angular-chart.js 294angular-chart.min.js 1, 1, 1angular-file-upload-shim.js 114angular-file-upload-shim.min.js 2, 2angular-file-upload.min.js 2, 2, 2angular-google-maps.min.js 6, 5, 7, 10, 6, 5, 10, 10, 9, 7,

5, 10, 7, 9, 5, 5, 7, 5, 6, 7, 8,5, 5, 9, 6, 6, 8, 6, 6, 10, 8, 7,7, 7, 5, 10, 8, 7, 5, 5, 5, 5, 7,5, 8, 9, 5, 6, 7, 8, 6, 10, 5, 6,7, 6, 5, 6, 10, 10, 5, 6, 8, 5,10, 7, 5, 5, 10

angular-loading-bar.js 80angular-loading-bar.min.js 7

Rule Variables should be declared before they are usedVariable 'barIndex' referenced before declaration.

File LineChart.js 2185, 51angular-animate.min.js 23, 11, 25, 21, 12, 12, 22, 25,

25, 21, 22, 25, 22, 22, 27, 15,27, 25, 26, 13, 25, 21, 9, 22,9

angular-block-ui.js 61, 514angular-file-upload-shim.js 194angular-resource.min.js 6, 8, 6, 7, 6, 9angular-route.min.js 6, 9, 9, 6, 6, 6, 6

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 11

Page 14: webstore

angular-store.js 136, 191, 247, 163ui-bootstrap-tpls.js 3825, 3009, 1642, 1643ui-bootstrap.js 3824, 1642, 1641, 3008angular.js 2209, 2227, 2192, 2217,

2205, 4954, 19938, 2195,2200, 18708, 2216, 19765,2223, 2212, 2208, 2220,2191, 2213, 2210, 16633,2206, 13223, 2204, 2218,2190, 2197, 7180, 19760,18472, 2221, 2187, 265,14279, 2198, 2188, 2193,2235, 2215, 2214, 2203,2219, 2225, 269, 2194,18471

Rule Sections of code should not be "commented out"Sections of code should not be "commented out".

File LineChart.js 1179, 1501, 1178, 1174,

1185, 1183, 1187, 485, 1180,1172, 1171, 1176, 1182,1184, 1442, 1175

angular-block-ui.js 290, 280, 660, 297, 284, 122,288, 294, 292, 295, 78, 170,174, 175, 171, 661, 172, 286,289, 112, 659, 176, 282

angular-file-upload-shim.js 185, 186, 184, 196, 187, 188angular-file-upload.js 224, 225, 223angular-store.js 280, 8, 118, 233, 6, 9, 10angular-ui-router.js 2153, 1237, 2152ui-bootstrap-tpls.js 1012ui-bootstrap.js 1011angular.js 10739, 10584, 24180, 24589,

1538, 4208CreateStoreController.js 73, 72EditStoreController.js 102, 101IndexController.js 13LoginController.js 22StoreApp.js 23, 139, 138, 130, 125, 133,

66, 43, 44, 140, 131, 134, 38,124, 129, 59, 42, 25

app.viewmodel.js 66, 38bootstrap.js 906, 1723, 82, 294, 1247,

177, 1832, 2005

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 12

Page 15: webstore

Rule Control flow statements "if", "for", "while", "switch" and "try" should not benested too deeply

Refactor this code to not nest more than 3 if/for/while/switch/try statements.

File LineChart.js 1899, 430, 1961, 1943, 1972,

1921, 949Chart.min.js 10, 10, 10, 10angular-animate.js 1487, 1327angular-chart.min.js 1angular-cookies.js 118angular-file-upload-shim.js 290, 144, 183, 131angular-file-upload-shim.min.js 2angular-file-upload.js 424, 144, 427, 441, 432, 214,

474angular-file-upload.min.js 2, 2angular-google-maps.min.js 10, 8, 10angular-mocks.js 2150angular-route.js 503, 529, 533, 525angular-route.min.js 11angular-ui-router.js 1013, 2255angular-ui-router.min.js 7, 7angular.js 7217, 818, 330, 315, 4929,

7442, 7708, 934, 14160,1563, 8187, 26076, 7363,16838, 16846, 929, 3470,5261, 14294, 26066, 7232,26072, 2629, 14191, 14336,7499, 7467, 9644, 6535,7199, 921, 7268, 26111, 913,926, 5277, 3087, 322, 17049,7830, 8201, 3093, 14143,6525, 16852, 2688, 7188,7267, 2960, 914, 26089,11963, 834, 7449, 9860

angular.min.js 12, 168, 40

Rule Require all gradient definitionsMissing gradient: -ms-(linear|radial)-gradient.*

File Line

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 13

Page 16: webstore

bootstrap-theme.css 378, 346, 264, 386, 396, 457,311, 417, 362, 285, 217, 311,150, 433, 370, 449, 264, 207,457, 449, 386, 228, 150, 124,320, 302, 98, 255, 72, 425,465, 72, 346, 465, 228, 362,354, 378, 338, 386, 240, 217,441, 338, 425, 320, 370, 285,302, 441, 255, 329, 124, 44,44, 207, 417, 354, 240, 433,176, 396, 98, 329, 176

bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5

Rule Disallow duplicate propertiesDuplicated property in the declarations

File Lineloading-bar.css 108, 109loading-bar.min.css 8, 8metro-bootstrap.css 3757, 752, 3672, 893, 2059,

891, 3803, 8133, 3511, 5918,911, 3574, 8450, 771, 8388,854, 1184, 3500, 3502, 1838,3499, 3770, 3639, 1126,3758, 8480, 3545, 8385,8456, 5885, 5905, 3498,5827, 3769, 8389, 3571,8132, 1837, 799, 5906, 7286,769, 751, 830, 1181, 5951,3501, 5917, 923, 770, 843,1171, 3670, 3512, 3625,1925, 8387, 842, 8491, 1182,5528, 3626, 8479, 8386, 912,922, 7237, 7234, 852, 2192,8454, 910, 841, 889, 5907,3629, 3572, 1186, 3575, 880,3627, 814, 5949, 3756, 831,3759, 5824, 5883, 3543,5823, 750, 5826, 3760, 3673,3804, 3628

Rule Require compatible vendor prefixesMissing vendor: -moz for property: transform

File LineSite.css 192, 192, 159, 196, 165, 165,

125, 159, 196, 38, 159, 186,182, 182, 196, 186, 186, 182,165, 38, 192

angular-block-ui.css 83, 88, 83, 88

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 14

Page 17: webstore

angular-block-ui.min.css 5, 5, 5, 5loading-bar.css 104, 92, 104, 93, 96, 101, 93,

101, 93, 97, 96, 101, 100,100, 92, 105, 100, 105, 97,96, 97, 92, 105, 104

loading-bar.min.css 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8

bootstrap-theme.css 297, 391, 228, 264, 465, 240,17, 7, 202, 413

bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5bootstrap.css 4270, 2873, 2545

Rule Disallow overqualified elementsDisallow overqualified elements

File LineHelpPage.css 14, 125Site.css 89, 118, 143, 136angular-block-ui.css 17angular-block-ui.min.css 5loading-bar.css 29, 21, 28, 22loading-bar.min.css 8, 8, 8, 8bootstrap-theme.css 410bootstrap-theme.min.css 5bootstrap.css 1371, 1517, 3119, 1390,

5250, 5222, 5208, 3215,3080, 2679, 3170, 3257,3164, 5288, 5266, 3299,4758, 2678, 5294, 3302,1384, 4915, 5244, 3254,3342, 3035, 3167, 3209,5272, 2894, 3074, 3122,5712, 4916, 3212, 1353,3077, 1396, 5203, 1378,5228, 2684, 4593, 3125,4839, 3376, 3260, 1359,2685, 1402, 3305, 1347,1365, 4491

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5

Rule Unused function parameters should be removedRemove the unused function parameter "index".

File LineChart.js 955, 2123Chart.min.js 10

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 15

Page 18: webstore

angular-animate.js 1375, 496angular-animate.min.js 17, 6angular-block-ui.js 152, 156, 189, 158angular-file-upload-shim.js 171, 175angular-file-upload.js 198, 246angular-mocks.js 152, 1699angular-route.js 6, 569angular-route.min.js 6, 11angular-ui-router.js 1124, 1107, 1706, 4043,

3477, 2825, 1088ui-bootstrap-tpls.js 3394, 1552, 28, 3808, 1327,

1354, 197, 1622, 1271, 2533,3205, 3413, 1387

ui-bootstrap.js 3412, 1551, 196, 2532, 1270,1386, 3807, 3393, 3204,1326, 1353, 27, 1621

angular.js 19754, 8327, 8320, 15141,22860, 20687, 10797, 23638,7126, 23203

angular.min.js 221, 96, 131, 224, 153, 159,229, 52

CreateStoreController.js 42, 17, 68CreateUserController.js 24, 26EditStoreController.js 56, 97, 18EditUserController.js 69, 34HomeController.js 4RegisterController.js 5, 143UserStoreController.js 5check-list-model.js 79LoginService.js 62, 44RegionService.js 4, 10, 18, 28, 35RegisterService.js 95, 10, 30, 115, 123, 4

Rule Functions should not have too many linesThis function has 138 lines, which is greater than the 100 lines authorized. Split it intosmaller functions.

File LineChart.js 910, 2326, 1884, 3135, 2764,

12, 2023, 1756, 2885, 1609,2510

angular-animate.js 632, 448, 485, 1587, 1282,1824

angular-block-ui.js 384, 388angular-breadcrumb.js 22, 35angular-chart.js 13, 78angular-file-upload.js 198, 332, 409, 32

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 16

Page 19: webstore

angular-loading-bar.js 35, 178, 167, 33angular-mocks.js 637, 308, 1093, 452, 292angular-resource.js 471, 444, 468, 325angular-route.js 236, 42angular-store.js 3, 67angular-ui-router.js 1229, 738, 1725, 3048, 318,

2144, 384, 1973, 3735, 348,2825

ui-bootstrap-tpls.js 2102, 3260, 1424, 2533,2536, 846, 1010, 3542, 2490,2094, 2435, 1435, 1927,2286, 1191, 713, 426, 2491,3536

ui-bootstrap.js 1434, 1423, 2434, 845, 2093,3535, 2532, 2489, 1009, 712,2101, 2490, 2535, 1190, 425,2285, 3259, 1926, 3541

angular.js 1761, 5431, 11331, 6647,24553, 2139, 10279

Rule "for...in" loops should filter properties before acting on themInsert an if statement at the beginning of this loop to filter items.

File LineChart.js 204Chart.min.js 10angular-animate.js 1327, 1952angular-animate.min.js 14, 25angular-cookies.js 98angular-cookies.min.js 6, 6, 6angular-file-upload.min.js 2, 2, 2angular-google-maps.min.js 6, 8, 9, 10, 10, 7, 8, 10, 10, 8,

6, 10, 8, 5, 6, 5, 7, 8, 8, 8, 6,8, 7, 7, 8, 10, 6, 8, 10, 8, 7,10, 10, 5, 6, 6, 8, 8, 5, 10, 5,8, 10, 8, 7, 7, 9, 7, 5, 7, 11,10, 10, 5, 6, 5, 6, 8, 7

angular-resource.min.js 6angular-ui-router.js 137angular-ui-router.min.js 7, 7, 7, 7angular.js 24642, 14409, 23926, 6988,

2964, 9461, 16844angular.min.js 7, 124, 168, 122, 28, 233, 79,

7, 246, 122, 234, 50, 161, 11,121

Rule Beware of box model size

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 17

Page 20: webstore

Possible box sizing issue

File LineSite.css 109, 110loading-bar.css 75loading-bar.min.css 8bootstrap.css 3740, 2714, 2545, 3763,

2766, 2751, 2442, 2729,2492, 4104, 4340, 4177,6231, 2699, 3414, 1157,1135, 5646, 5653, 4235,6220, 2736

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5

metro-bootstrap-responsive.css 250metro-bootstrap-responsive.min.css 1metro-bootstrap.css 8392, 7156, 2474, 7447,

1133, 8005, 2524, 2370,2632, 6594, 2175, 8375,5306, 4929, 3400, 1158,7169, 4383, 5957, 6459,4896, 7640, 7, 7616, 6006,5871, 2968, 8224, 6506, 60,3809, 6616, 2620, 3858,6668, 7607, 7358, 3727,3035, 6217, 7765, 3692,8511, 1246, 5797, 1822,7710, 7164, 7534, 7735

Rule Named function expressions should not be usedMake this function anonymous by removing its name: 'function() {...}'.

File Lineangular-breadcrumb.js 245, 199angular-chart.js 79angular-file-upload.js 446angular-file-upload.min.js 2angular-mocks.js 141, 772angular-route.js 872angular-ui-router.js 1200, 3525, 1687, 1555,

3048, 3006, 3291, 3351,2936, 1189, 3840, 3394

ui-bootstrap-tpls.js 3168, 2471, 2995, 3206, 337,2980, 2491, 3006, 2536,2737, 2154, 2745, 2189

ui-bootstrap.js 2736, 3005, 2470, 336, 2535,2153, 2490, 2744, 2188,2979, 2994, 3167, 3205

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 18

Page 21: webstore

angular.js 25764, 23405, 12256, 25917,6914, 20582, 14007, 23611,12151, 12204, 6902, 12238,12337, 10213, 22075, 20515,15141, 20380, 13925, 24869,7705, 11457, 12707, 1761,22328, 18182, 8058, 4587,10190, 13985, 25230, 4995,20587, 24553, 8004, 25088,10419, 24169, 12912, 25244,4481, 12868, 13392, 21563,6897, 20450, 25030, 12169,20384, 1454, 14926, 6923,15722, 3290

Rule Disallow selectors that look like regular expressionsDisallow regular expression like selectors

File Linebootstrap.css 212, 2326, 2321, 3728, 2327,

213bootstrap.min.css 5, 5, 5, 5, 5, 5iconFont.min.css 1, 1, 1metro-bootstrap-responsive.css 257, 262, 130, 152, 276, 271,

157, 125metro-bootstrap-responsive.min.css 1, 1, 1, 1, 1, 1, 1, 1metro-bootstrap.css 5136, 3211, 2951, 6709,

3207, 6758, 2155, 1932,7251, 1941, 4145, 3209,1459, 6737, 3204, 6884,6881, 7312, 4143, 4915,2948, 3208, 8342, 6208,2141, 4405, 2168, 6755,5845, 4414, 156, 4197, 5590,3205, 3206, 7298, 2254,2950, 7214, 4198, 1412,7265, 8194, 4144, 1726,2119, 3333, 1928, 2947,1802, 2274, 3332, 6863,3334, 5068, 6835, 1935,2949, 1556, 1555, 1898,2946, 3210, 1417, 4142,1462, 1938, 157

metro-bootstrap.min.css 1

Rule Bitwise operators should not be usedRemove the use of "&" operator.

File Lineangular-chart.js 239, 239, 240, 241, 240angular-chart.min.js 1, 1, 1, 1, 1

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 19

Page 22: webstore

angular-google-maps.min.js 9, 10, 9, 9, 10, 10, 9, 9, 9, 9,9, 9

angular-ui-router.js 88angular-ui-router.min.js 7angular.js 216, 20695, 210, 24488,

20696, 216angular.min.js 159, 231, 159bootstrap.js 1642, 824, 1642bootstrap.min.js 6, 6, 6jquery-2.1.3.js 1331, 705, 599, 927, 705,

1314, 1875, 4533, 4533,3291, 705, 1273, 4533, 926,2557, 705

jquery-2.1.3.min.js 2, 2, 2, 2, 3, 3, 3, 2, 2, 2, 2, 2,2, 2, 2, 2

knockout-3.3.0.debug.js 366, 897knockout-3.3.0.js 15, 29, 29lodash.js 4258, 2636, 4258, 3686,

3554, 3515, 7511, 807, 5743,1957, 3516, 4255, 1956,3518, 3716, 3620, 4280,3553, 4242, 7420, 3692,4248, 2867, 3514

Rule Disallow IDs in selectorsDisallow IDs in selectors

File LineHelpPage.css 7, 125Site.css 136, 46, 100, 93, 89, 125, 61,

73, 52, 126, 143loading-bar.css 75, 29, 67, 33, 9, 22, 10, 19,

26, 28, 27, 21, 20, 51loading-bar.min.css 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,

8, 8metro-bootstrap-responsive.css 41, 26, 11, 15, 47, 32, 38, 50,

29, 19, 44, 35metro-bootstrap-responsive.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1metro-bootstrap.css 3468, 695, 4363, 3460, 708,

714, 3455, 699, 717, 702,497, 484, 723, 711, 4358,705, 67, 720, 692, 487, 4368

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1

Rule Dead Stores should be removedRemove this useless assignment to local variable "lastRotated"

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 20

Page 23: webstore

File LineChart.js 1558Chart.min.js 10angular-block-ui.min.js 6angular-google-maps.min.js 10, 6, 8, 10, 7, 8, 7, 7, 8, 6, 8,

8, 8, 5, 5, 5, 5, 6, 8, 5, 8, 6, 8,10, 5, 7, 5, 8, 6, 7, 5, 6, 8, 6,5, 10, 9, 7, 7, 8, 8, 8, 7, 8, 8,6, 6, 8, 8, 8, 6, 8, 7, 8, 8, 7, 5,8, 8, 10, 9, 8, 5, 6, 8, 5, 6, 5,8, 7, 8, 8, 8, 7, 6, 7, 5

angular.js 12183, 12251, 25634bootstrap.min.js 6jquery-2.1.3.js 294jquery-2.1.3.min.js 2knockout.validation.min.js 10angular-translate.js 2324angular-translate.min.js 6ui-utils.js 1359ui-utils.min.js 7

Rule Variables and functions should not be redeclaredRename "width" as this name is already used in declaration at line 40.

File LineChart.js 47, 48Chart.min.js 10, 10angular-animate.min.js 24, 23, 13, 27, 24, 23, 20, 11,

27angular-file-upload-shim.js 353, 357angular-file-upload-shim.min.js 2, 2angular-file-upload.js 439angular-file-upload.min.js 2angular-resource.min.js 7angular-route.min.js 6angular.js 16084angular.min.js 188, 79, 72, 72, 72, 169, 144,

144, 230, 109, 72, 28, 72,201, 208, 159, 71, 71, 80,144, 159, 232, 170, 159, 159,66, 132, 107, 72

knockout-3.3.0.debug.js 291, 5041, 1593, 291, 5331knockout-3.3.0.js 112, 42, 25, 76, 100, 27, 76,

111, 96, 112, 61, 60, 42, 20,27, 29, 105, 42

lodash.js 9701

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 21

Page 24: webstore

metro.min.js 130, 147, 58, 119, 131, 19,109, 131, 136, 131, 19, 139,129, 109

Rule Disallow universal selectorDisallow universal selector as key part

File Linebootstrap.css 195, 1078, 1072bootstrap.min.css 5metro-bootstrap.css 1759, 2079, 8302, 2211,

3267, 15, 5085, 8299, 1858,1855, 8013, 8154, 1118,2214, 1674, 5547, 1638, 132,1762, 1686, 1677, 139, 8151,1683, 3272, 2076, 5550

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1, 1

Rule Unused local variables should be removedRemove the declaration of the unused 'getAngleFromPoint' variable.

File LineChart.js 341, 1219, 2301, 383, 506,

253, 1548, 748, 242, 1593,22, 362, 1803, 687, 774, 316,708, 265

angular-animate.js 442, 1715angular-store.js 354angular-ui-router.js 4011, 787, 909ui-bootstrap-tpls.js 145, 457ui-bootstrap.js 1686, 144, 456angular.js 23926, 14260, 49angular.min.js 161CreateStoreController.js 70, 71EditStoreController.js 99, 100knockout-3.3.0.debug.js 796knockout.validation.js 1095, 1056, 1255, 1055,

1094, 1254lodash.js 965, 4404, 12043sammy-0.7.5.js 1108, 1640sammy-0.7.5.min.js 5, 5

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 22

Page 25: webstore

Rule Disallow units for zero valuesDisallow zero values with units

File LineHelpPage.css 33, 73, 73, 33, 52, 73, 82, 53,

33, 82, 82Site.css 109, 110, 110, 109loading-bar.css 100, 104, 108, 96, 92loading-bar.min.css 8, 8, 8, 8, 8metro-bootstrap.css 7137, 4833, 3593, 4833,

7186, 5607, 2149, 1819,6474, 6580, 3359, 8359,2271, 2136, 2364, 3552,5637, 7338, 1915, 8211

Rule Require standard property with vendor prefixNo standard property defined after

File LineSite.css 166, 197, 40, 187, 41, 193,

132, 131, 183, 160, 207, 206loading-bar.css 12loading-bar.min.css 8bootstrap.css 162, 2446, 132, 2593, 11,

166, 10, 5713, 1086bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5metro-bootstrap.css 106, 115, 3364, 2979, 92metro-bootstrap.min.css 1, 1, 1, 1, 1

Rule [Functions|Methods|Lambdas] should not have too many parametersFunction has 8 parameters which is greater than 7 authorized.

File Lineangular-animate.js 1282, 485angular-animate.min.js 12, 7angular-file-upload.js 517angular-file-upload.min.js 2angular-google-maps.min.js 6, 7, 7, 8, 6, 6, 5, 6, 6, 7angular-route.js 236angular-route.min.js 9angular-ui-router.js 2825ui-bootstrap-tpls.js 1010ui-bootstrap-tpls.min.js 8ui-bootstrap.js 1009ui-bootstrap.min.js 8

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 23

Page 26: webstore

angular.js 6647, 9785, 7318, 20116,7908, 22818

angular.min.js 211, 64, 85, 220, 49, 55EditUserController.js 5LoginController.js 3RegisterController.js 5UserStoreController.js 5lodash.js 3513, 3685

Rule Nested blocks of code should not be left emptyEither remove or fill this block of code.

File Lineangular-file-upload-shim.min.js 2angular-google-maps.min.js 10ui-bootstrap-tpls.js 1254ui-bootstrap.js 1253angular.js 11647, 1086angular.min.js 14, 49, 54, 14, 40, 102jquery-2.1.3.js 8517, 2954, 3739, 5324,

4072, 1417, 739, 839jquery-2.1.3.min.js 2, 3, 2, 3, 4, 2knockout-3.3.0.debug.js 476, 102knockout-3.3.0.js 18, 113lodash.js 784, 625, 2816, 408, 768,

424, 640jquery.ui.widget.js 16modernizr-2.8.3.js 765, 743

Rule Array and Object constructors should not be usedUse a literal instead of the Array constructor.

File LineChart.js 507Chart.min.js 10ui-bootstrap-tpls.js 1209, 1239, 1310, 2905,

1371ui-bootstrap-tpls.min.js 8, 8, 8, 9, 8ui-bootstrap.js 2904, 1208, 1370, 1238,

1309ui-bootstrap.min.js 8, 8, 8, 9, 8angular.js 7078, 13958, 25883, 13957,

24613, 10193, 14184jquery-2.1.3.js 3343, 3344, 3345

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 24

Page 27: webstore

jquery-2.1.3.min.js 2, 2, 2lodash.js 1823

Rule Require properties appropriate for displayUnnecessary property with display

File Linebootstrap.css 4026, 3703, 2321, 2326,

3961bootstrap.min.css 5, 5, 5, 5, 5metro-bootstrap.css 3481, 5656, 3739, 8117,

5513, 1998, 5887, 3608,1555, 2279, 3460, 4990,7058

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1

Rule Functions should not be defined inside loopsDefine this function outside of a loop.

File LineChart.min.js 10angular-google-maps.min.js 9, 5angular-mocks.js 545angular.js 7181, 24681, 12169, 24628,

3083angular.min.js 234, 169, 193, 234, 80, 53CreateUserController.js 64EditUserController.js 83RegisterController.js 219jquery-2.1.3.min.js 2, 2, 2knockout-3.3.0.debug.js 5277knockout-3.3.0.js 19, 38, 111, 19lodash.js 11239metro.min.js 80sammy-0.7.5.js 1705sammy-0.7.5.min.js 5angular-translate.min.js 6, 6ui-utils.min.js 7, 7, 7

Rule "switch" statements should end with a "default" clauseAvoid switch statement without a "default" clause.

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 25

Page 28: webstore

File LineChart.js 1347, 1324Chart.min.js 10, 10angular-google-maps.min.js 6, 9angular.js 7673, 7161angular.min.js 52, 57RegisterController.js 95knockout-3.3.0.debug.js 5287, 3071, 2029, 3395knockout-3.3.0.js 111, 69, 49, 73knockout.validation.js 155knockout.validation.min.js 10lodash.js 2940, 4082, 4024, 3792,

8118metro.min.js 51ui-utils.js 1053ui-utils.min.js 7

Rule Collapsible "if" statements should be mergedMerge this if statement with the nested one.

File LineChart.js 322, 1830angular-animate.js 591angular-chart.js 100angular-route.js 501angular-ui-router.js 3112angular.js 910, 11403, 7575, 7187HomeController.js 12jquery-2.1.3.js 2108, 4160, 4360, 4432,

2169, 2508, 4362jquery.signalR-2.2.0.js 2390, 1888knockout-3.3.0.debug.js 666knockout.validation.js 545respond.js 124respond.matchmedia.addListener.js 173angular-translate.js 1862ui-utils.js 1382

Rule Sections of code should not be "commented out"Remove this commented out code.

File LineBundleConfig.cs 24

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 26

Page 29: webstore

Startup.Auth.cs 87, 83, 90, 93, 79HelpPageConfig.cs 76, 64, 68, 72, 43, 45, 37, 80HelpPageConfigurationExtensions.cs 287, 275, 277XmlDocumentationProvider.cs 142AccountController.cs 226, 174StoreHub.cs 42, 36, 29

Rule Files should not have too many linesFile "Chart.js" has 3.477 lines, which is greater than 1.000 authorized. Split it into smallerfiles.

File LineChart.js N/Aangular-animate.js N/Aangular-mocks.js N/Aangular-ui-router.js N/Aui-bootstrap-tpls.js N/Aui-bootstrap.js N/Aangular.js N/APayPhoneErrors.js N/Abootstrap.js N/Ajquery-2.1.3.intellisense.js N/Ajquery-2.1.3.js N/Ajquery.signalR-2.2.0.js N/Aknockout-3.3.0.debug.js N/Aknockout.validation.js N/Alodash.js N/Amodernizr-2.8.3.js N/Asammy-0.7.5.js N/Aangular-translate.js N/Aui-utils.js N/A

Rule Loops should not contain more than a single "break" or "continue"statement

Reduce the total number of "break" and "continue" statements in this loop to use one atmost.

File Lineangular-file-upload.js 421angular-file-upload.min.js 2angular-google-maps.min.js 10, 10, 10angular-ui-router.js 111, 2249jquery-2.1.3.js 2501

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 27

Page 30: webstore

jquery-2.1.3.min.js 2knockout-3.3.0.debug.js 2217knockout-3.3.0.js 52knockout.validation.js 661lodash.js 1170, 1176ui-utils.js 2199

Rule Bulletproof font faceFirst web font has missing query string or it is not eot

File Linebootstrap.css 267bootstrap.min.css 5iconFont.min.css 1metro-bootstrap.css 662, 668, 656, 674, 8419metro-bootstrap.min.css 1, 1, 1, 1, 1

Rule Disallow duplicate background imagesDisallow duplicate background images

File Linemetro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1

Rule Two branches in the same conditional structure should not have exactlythe same implementation

Either merge this branch with the identical one on line "1961" or change one of theimplementations.

File LineChart.js 1963angular-google-maps.min.js 9angular.js 4121, 12329, 4475, 11915,

4472angular.min.js 187jquery.signalR-2.2.0.js 361

Rule Constructor functions should not be called purely for side-effectsReplace by a standard call to the function.

File LineChart.js 1027, 999

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 28

Page 31: webstore

1.5. Most violated files by level with priority up to info

BLOCKER violations

CRITICAL violations

Chart.min.js 10, 10angular.js 956angular.min.js 162knockout-3.3.0.debug.js 5042, 5037

Rule Variables should always be declared with "var"Add the "var" keyword to this declaration of "FormData".

File Lineangular-file-upload-shim.js 250, 267angular-file-upload-shim.min.js 2, 2metro.min.js 44, 75, 19

File ViolationsStoreRoutes.js 18jquery-2.1.3.intellisense.js 6RegisterService.js 4StoreService.js 2UserStoreService.js 2LoginService.js 2RegisterController.js 1

File Violationslodash.js 21angular.min.js 4jquery-2.1.3.min.js 3angular.js 3angular-google-maps.min.js 2angular-resource.js 2angular-resource.min.js 2knockout-3.3.0.debug.js 2knockout-3.3.0.js 2

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 29

Page 32: webstore

MAJOR violations

MINOR violations

File Violationsangular-google-maps.min.js 3,659metro-bootstrap.css 2,241metro-bootstrap.min.css 2,233angular.min.js 1,870jquery-2.1.3.min.js 1,779angular.js 760knockout-3.3.0.js 740metro.min.js 729ui-utils.min.js 547bootstrap.css 532bootstrap.min.css 530knockout-3.3.0.debug.js 444angular-ui-router.min.js 419Chart.min.js 417ui-bootstrap.min.js 399ui-bootstrap-tpls.min.js 399bootstrap.min.js 392lodash.js 357jquery.signalR-2.2.0.min.js 347angular-translate.min.js 336jquery-2.1.3.js 309bootstrap.js 246sammy-0.7.5.js 236knockout.validation.min.js 230angular-animate.min.js 215angular-ui-router.js 196Chart.js 138angular-file-upload.min.js 136metro-bootstrap-responsive.css 126metro-bootstrap-responsive.min.css 126angular-file-upload-shim.min.js 103bootstrap-theme.css 84bootstrap-theme.min.css 84ui-bootstrap.js 80

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 30

Page 33: webstore

INFO violations

1.6. Additional information

File ViolationsNo violations

File ViolationsNo violations

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 31

Page 34: webstore

2. PayPhone.WebStore2.1. Dashboard

Lines of code75,294N/A packages69 classes22,055 methods9.6% duplicated lines

Comments28.5%30,032 comment lines

Complexity9.59.3 /class40,623 decision points

Code CoverageN/AN/A tests

Test SuccessN/AN/A failuresN/A errors

Technical Debt1.226d

Violations34,380

Blocker 35Critical 41Major 23,006Minor 10,748Info 550

LCOM4N/AN/A files having LCOM4>1

RFCN/A/class

Package tangleindexN/AN/A cycles

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 32

Page 35: webstore

2.2. Hotspots

2.3. New issues in the last 30 days

Most violated rulesTrailing commas should not be used 35 BLOCKERIdentical expressions should not be used onboth sides of a binary operator

25 CRITICAL

Switch cases should end with anunconditional "break" statement

10 CRITICAL

Relational operators should be used in "for"loop termination conditions

3 CRITICAL

"for" loop incrementers should modify thevariable being tested in the loop's stopcondition

2 CRITICAL

Most violated filesangular-google-maps.min.js 5,240angular.min.js 3,558jquery-2.1.3.min.js 2,451metro-bootstrap.css 2,241metro-bootstrap.min.css 2,233

Most complex filesangular.js 3,784angular.min.js 3,569angular-google-maps.min.js 3,389jquery-2.1.3.js 2,644jquery-2.1.3.min.js 2,561

Most duplicated filesui-bootstrap-tpls.js 4,199ui-bootstrap.js 3,890jquery-2.1.3.intellisense.js 2,554respond.matchmedia.addListener.js 227respond.js 222

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 33

Page 36: webstore

Rule Require compatible vendor prefixesMissing vendor: -moz for property: transform

File LineSite.css 192, 192, 159, 196, 165, 165,

125, 159, 196, 38, 159, 186,182, 182, 196, 186

Rule Expressions should not be too complexReduce the number of conditional operators (7) used in the expression (maximum allowed3).

File LineModelDescriptionGenerator.cs 244HelpPageSampleGenerator.cs 423HelpPageSampleKey.cs 141ObjectGenerator.cs 189

Rule Disallow overqualified elementsDisallow overqualified elements

File LineHelpPage.css 14, 125Site.css 89, 118, 143

Rule Disallow !importantDisallow !important

File LineSite.css 39, 212, 40, 41, 233, 229,

218, 213

Rule Disallow empty rulesEmpty rule

File LineSite.css 61

Rule Exceptions should not be ignoredHandle the exception, rather than swallow it with an empty statement.

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 34

Page 37: webstore

File LineHelpPageSampleGenerator.cs 200

Rule Method parameters and caught exceptions should not be reassignedIntroduce a new variable instead of reusing the parameter "modelType".

File LineModelDescriptionGenerator.cs 120

Rule Disallow overspecified selectorsDisallow overspecified selectors

File LineHelpPage.css 58Site.css 217

Rule Methods should not be too complexThe Cyclomatic Complexity of this method is 27 which is greater than 10 authorized).

File LineModelDescriptionGenerator.cs 110ObjectGenerator.cs 104, 38

Rule Require standard property with vendor prefixNo standard property defined after

File LineSite.css 166, 197, 40, 187, 41, 193,

132, 131, 183

Rule Disallow units for zero valuesDisallow zero values with units

File LineHelpPage.css 33, 73, 73, 33, 52, 73, 82, 53,

33, 82, 82Site.css 109, 110, 110

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 35

Page 38: webstore

2.4. Violations details with priority up to info

BLOCKER violations

Rule Sections of code should not be "commented out"Remove this commented out code.

File LineBundleConfig.cs 24Startup.Auth.cs 87, 83, 90, 93, 79HelpPageConfig.cs 76, 64, 68, 72, 43, 45, 37, 80HelpPageConfigurationExtensions.cs 287, 275, 277XmlDocumentationProvider.cs 142

Rule Disallow IDs in selectorsDisallow IDs in selectors

File LineHelpPage.css 7, 125Site.css 136, 46, 100, 93, 89, 125, 61,

73, 52, 126, 143

Rule "switch" statements should end with a "default" clauseAdd a "default" clause to this switch statement.

File LineHelpPageSampleGenerator.cs 407

Rule Beware of box model sizePossible box sizing issue

File LineSite.css 109

Rule Lines should not be too longSplit this 217 characters long line (which is greater than 200 authorized).

File LineHelpPageSampleGenerator.cs 234, 149ObjectGenerator.cs 28

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 36

Page 39: webstore

CRITICAL violations

Rule Trailing commas should not be usedAvoid trailing comma in array and object literals.

File LineRegisterController.js 179StoreRoutes.js 197, 141, 147, 127, 211, 111,

169, 26, 161, 155, 175, 203,41, 73, 189, 133, 183, 57

LoginService.js 53, 16RegisterService.js 138, 27, 45, 78StoreService.js 41, 60UserStoreService.js 62, 97jquery-2.1.3.intellisense.js 2640, 496, 426, 1, 635, 711

Rule Identical expressions should not be used on both sides of a binaryoperator

Identical sub-expressions on both sides of operator "/"

File Lineangular-google-maps.min.js 9, 9angular.js 19977angular.min.js 155jquery-2.1.3.min.js 3lodash.js 1643, 2905, 2865, 3875,

2758, 5036, 4221, 2451,4162, 4062, 5177, 2512,2451, 2512, 297, 1643, 4409,296, 3876, 1878

Rule Switch cases should end with an unconditional "break" statementLast statement in this switch-clause should be an unconditional break.

File Lineangular-resource.js 481, 476angular-resource.min.js 7, 7angular.js 16774angular.min.js 141knockout-3.3.0.debug.js 1577, 1569knockout-3.3.0.js 42, 42

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 37

Page 40: webstore

MAJOR violations

Rule Relational operators should be used in "for" loop termination conditionsReplace '!=' operator with one of '<=', '>=', '<', or '>' comparison operators.

File Lineangular.min.js 19jquery-2.1.3.min.js 3, 3

Rule "for" loop incrementers should modify the variable being tested in theloop's stop condition

This loop's stop condition tests "element.length" but the incrementer updates "i".

File Lineangular.js 12489angular.min.js 103

Rule Local variables should not shadow "undefined"Rename this variable.

File Linelodash.js 13

Rule Assignments should not be made from within sub-expressionsExtract the assignment out of this expression.

File LineChart.js 546, 588, 644, 585, 592, 556,

605, 658, 550, 536, 645, 640,645, 632, 631, 560, 636, 540,478, 553, 656, 654

Chart.min.js 10, 10, 10, 10, 10, 10, 10, 11,10, 10, 10, 10, 10, 10, 10, 10,10, 11, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 11, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 11, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 11, 10,11, 10, 11, 11, 10, 10, 10, 10,10, 10, 10, 10, 10, 10

Rule Comma operator should not be used

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 38

Page 41: webstore

Remove use of this comma operator.

File LineChart.min.js 11, 10, 10, 10, 11, 11, 10, 10,

10, 10, 10, 10, 11, 10, 11, 11,11, 10, 10, 10, 10, 10, 11, 10,10, 10, 10, 10, 10, 10, 10, 11,10, 11, 10, 11, 11, 10, 10, 10,11, 10, 10, 11, 10, 10, 10, 10,10, 11, 10, 10, 11, 10, 10, 10,11, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 11, 10, 11,10, 10, 10, 10, 11, 10, 10, 10,11, 10, 10, 10, 10, 10, 11, 10,10, 10, 10, 10, 10, 11, 10, 10,11, 10, 10, 10

Rule Control structures should always use curly bracesMissing curly brace.

File LineChart.js 611, 539, 529, 644, 600, 599,

598, 912, 237, 631, 303, 613,580, 549, 213, 630, 624, 625,3010, 612, 2412, 750, 2665,591, 578, 626, 579, 220, 288,559, 584, 617, 662, 604

Chart.min.js 10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 11,10, 10, 11, 10, 10, 10, 10, 10,10, 10, 10, 10, 10, 10, 10, 10,10, 10, 10, 10

angular-animate.js 1219, 1553, 497, 718, 1218angular-animate.min.js 26, 28, 20, 16, 16, 31, 14, 16,

16, 19, 15, 13, 14, 9, 21, 14,25, 28, 17, 24, 14, 28, 31, 13,6

Rule Disallow !importantDisallow !important

File LineSite.css 39, 212, 40, 41, 233, 229,

218, 213

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 39

Page 42: webstore

bootstrap.css 243, 6504, 6369, 6556, 6429,199, 6405, 6495, 6449, 6560,6568, 197, 6409, 6356, 6435,6347, 6572, 6353, 6465, 250,4108, 6419, 256, 6499, 6399,6519, 6548, 6484, 4106,6424, 4388, 6469, 6474, 260,6350, 6538, 4391, 200, 198,6576, 6581, 6534, 4105,6509, 6439, 6395, 264, 6454,6524, 6444, 6381, 6489,6514, 6414, 230, 6459, 6479,6564, 6552, 196, 6529, 6542

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5

Rule Disallow overspecified selectorsDisallow overspecified selectors

File LineHelpPage.css 58Site.css 217bootstrap-theme.css 264, 240, 287, 265, 286, 241,

276, 285bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5bootstrap.css 2418, 4462, 5436, 2456,

2385, 2395, 2338, 4416,2263, 2432, 4249, 2453,2474, 2475, 5501, 4463,5535, 5456, 5507, 2374,4525, 2336, 5390, 2433,2297, 4524, 5411, 2354,5618, 4457, 2392, 5440,4447, 2359, 5466, 2390,5643, 2350, 5494, 5414,2454, 2339, 2343, 5480,2294, 5445, 5498, 2347,2295, 2293, 5582, 5478,2399, 2384, 2332, 5410,2341, 5433, 4464, 2412,2424, 2402, 5402, 2382,4517, 2279, 2265, 2471,2307, 2346, 5464, 2361,2280, 2348, 2312, 4458,4470, 4518, 5465, 4417,4566, 4512

Rule "===" and "!==" should be used instead of "==" and "!="Replace "==" with "===".

File Line

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 40

Page 43: webstore

Chart.js 612, 625, 305, 303, 599Chart.min.js 10, 10, 10, 10, 10, 10, 10, 10angular-animate.js 693, 1706, 1371, 663, 1357,

1338, 1355, 1827, 480, 1323,1415, 665, 588, 664, 1487,1357, 1333, 593, 465, 661

angular-animate.min.js 15, 9, 14, 14, 8, 25, 14, 11,14, 9, 13, 14, 6, 11, 7, 11, 22,11, 13, 14

angular-block-ui.js 344angular-block-ui.min.js 6angular-breadcrumb.min.js 4angular-chart.min.js 1, 1, 1, 1, 1, 1, 1, 1angular-cookies.js 62angular-cookies.min.js 6angular-file-upload-shim.js 241, 15, 110, 114angular-file-upload-shim.min.js 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,

2angular-file-upload.js 397, 388, 420, 222, 572, 397,

451, 340, 522angular-file-upload.min.js 2, 2, 2, 2, 2, 2, 2, 2

Rule Functions should not be too complexFunction has a complexity of 12 which is greater than 10 authorized.

File LineChart.js 1756, 383, 1884, 910Chart.min.js 10, 10, 10, 10angular-animate.js 1824, 1151, 1539, 1761,

1282, 632angular-animate.min.js 23, 16, 12, 19, 9, 25angular-breadcrumb.js 56angular-breadcrumb.min.js 4angular-chart.js 108angular-file-upload-shim.js 102angular-file-upload-shim.min.js 2angular-file-upload.js 124, 409, 232, 391angular-file-upload.min.js 2, 2, 2, 2angular-google-maps.min.js 6, 6, 6, 10, 9, 6, 5, 5, 10, 5, 8,

5, 8, 10, 7, 10, 9, 9, 6, 9, 8, 9,9, 10, 6, 10, 5, 10, 6, 9, 9, 7,5, 9, 8, 9, 9, 8

angular-loading-bar.js 74, 254angular-loading-bar.min.js 7angular-mocks.js 1553, 1533, 1111angular-resource.js 471angular-resource.min.js 7, 6

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 41

Page 44: webstore

angular-route.js 487angular-route.min.js 9angular-store.js 156, 281, 324, 119angular-ui-router.js 1985, 738, 384, 2286, 3351,

84, 2091, 1593, 2171, 902,3048, 3164, 992, 2236

Rule Expressions should not be too complexReduce the number of conditional operators (5) used in the expression (maximum allowed3).

File LineChart.js 678, 1554, 668Chart.min.js 10, 10, 10, 10, 10, 10, 10angular-animate.js 1413angular-animate.min.js 29, 8, 15, 14, 26angular-block-ui.min.js 6, 6angular-breadcrumb.min.js 4angular-chart.js 294angular-chart.min.js 1, 1, 1angular-file-upload-shim.js 114angular-file-upload-shim.min.js 2, 2angular-file-upload.min.js 2, 2, 2angular-google-maps.min.js 6, 5, 7, 10, 6, 5, 10, 10, 9, 7,

5, 10, 7, 9, 5, 5, 7, 5, 6, 7, 8,5, 5, 9, 6, 6, 8, 6, 6, 10, 8, 7,7, 7, 5, 10, 8, 7, 5, 5, 5, 5, 7,5, 8, 9, 5, 6, 7, 8, 6, 10, 5, 6,7, 6, 5, 6, 10, 10, 5, 6, 8, 5,10, 7, 5, 5, 10

angular-loading-bar.js 80angular-loading-bar.min.js 7

Rule Variables should be declared before they are usedVariable 'barIndex' referenced before declaration.

File LineChart.js 2185, 51angular-animate.min.js 23, 11, 25, 21, 12, 12, 22, 25,

25, 21, 22, 25, 22, 22, 27, 15,27, 25, 26, 13, 25, 21, 9, 22,9

angular-block-ui.js 61, 514angular-file-upload-shim.js 194angular-resource.min.js 6, 8, 6, 7, 6, 9angular-route.min.js 6, 9, 9, 6, 6, 6, 6

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 42

Page 45: webstore

angular-store.js 136, 191, 247, 163ui-bootstrap-tpls.js 3825, 3009, 1642, 1643ui-bootstrap.js 3824, 1642, 1641, 3008angular.js 2209, 2227, 2192, 2217,

2205, 4954, 19938, 2195,2200, 18708, 2216, 19765,2223, 2212, 2208, 2220,2191, 2213, 2210, 16633,2206, 13223, 2204, 2218,2190, 2197, 7180, 19760,18472, 2221, 2187, 265,14279, 2198, 2188, 2193,2235, 2215, 2214, 2203,2219, 2225, 269, 2194,18471

Rule Sections of code should not be "commented out"Sections of code should not be "commented out".

File LineChart.js 1179, 1501, 1178, 1174,

1185, 1183, 1187, 485, 1180,1172, 1171, 1176, 1182,1184, 1442, 1175

angular-block-ui.js 290, 280, 660, 297, 284, 122,288, 294, 292, 295, 78, 170,174, 175, 171, 661, 172, 286,289, 112, 659, 176, 282

angular-file-upload-shim.js 185, 186, 184, 196, 187, 188angular-file-upload.js 224, 225, 223angular-store.js 280, 8, 118, 233, 6, 9, 10angular-ui-router.js 2153, 1237, 2152ui-bootstrap-tpls.js 1012ui-bootstrap.js 1011angular.js 10739, 10584, 24180, 24589,

1538, 4208CreateStoreController.js 73, 72EditStoreController.js 102, 101IndexController.js 13LoginController.js 22StoreApp.js 23, 139, 138, 130, 125, 133,

66, 43, 44, 140, 131, 134, 38,124, 129, 59, 42, 25

app.viewmodel.js 66, 38bootstrap.js 906, 1723, 82, 294, 1247,

177, 1832, 2005

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 43

Page 46: webstore

Rule Control flow statements "if", "for", "while", "switch" and "try" should not benested too deeply

Refactor this code to not nest more than 3 if/for/while/switch/try statements.

File LineChart.js 1899, 430, 1961, 1943, 1972,

1921, 949Chart.min.js 10, 10, 10, 10angular-animate.js 1487, 1327angular-chart.min.js 1angular-cookies.js 118angular-file-upload-shim.js 290, 144, 183, 131angular-file-upload-shim.min.js 2angular-file-upload.js 424, 144, 427, 441, 432, 214,

474angular-file-upload.min.js 2, 2angular-google-maps.min.js 10, 8, 10angular-mocks.js 2150angular-route.js 503, 529, 533, 525angular-route.min.js 11angular-ui-router.js 1013, 2255angular-ui-router.min.js 7, 7angular.js 7217, 818, 330, 315, 4929,

7442, 7708, 934, 14160,1563, 8187, 26076, 7363,16838, 16846, 929, 3470,5261, 14294, 26066, 7232,26072, 2629, 14191, 14336,7499, 7467, 9644, 6535,7199, 921, 7268, 26111, 913,926, 5277, 3087, 322, 17049,7830, 8201, 3093, 14143,6525, 16852, 2688, 7188,7267, 2960, 914, 26089,11963, 834, 7449, 9860

angular.min.js 12, 168, 40

Rule Require all gradient definitionsMissing gradient: -ms-(linear|radial)-gradient.*

File Line

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 44

Page 47: webstore

bootstrap-theme.css 378, 346, 264, 386, 396, 457,311, 417, 362, 285, 217, 311,150, 433, 370, 449, 264, 207,457, 449, 386, 228, 150, 124,320, 302, 98, 255, 72, 425,465, 72, 346, 465, 228, 362,354, 378, 338, 386, 240, 217,441, 338, 425, 320, 370, 285,302, 441, 255, 329, 124, 44,44, 207, 417, 354, 240, 433,176, 396, 98, 329, 176

bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5

Rule Disallow duplicate propertiesDuplicated property in the declarations

File Lineloading-bar.css 108, 109loading-bar.min.css 8, 8metro-bootstrap.css 3757, 752, 3672, 893, 2059,

891, 3803, 8133, 3511, 5918,911, 3574, 8450, 771, 8388,854, 1184, 3500, 3502, 1838,3499, 3770, 3639, 1126,3758, 8480, 3545, 8385,8456, 5885, 5905, 3498,5827, 3769, 8389, 3571,8132, 1837, 799, 5906, 7286,769, 751, 830, 1181, 5951,3501, 5917, 923, 770, 843,1171, 3670, 3512, 3625,1925, 8387, 842, 8491, 1182,5528, 3626, 8479, 8386, 912,922, 7237, 7234, 852, 2192,8454, 910, 841, 889, 5907,3629, 3572, 1186, 3575, 880,3627, 814, 5949, 3756, 831,3759, 5824, 5883, 3543,5823, 750, 5826, 3760, 3673,3804, 3628

Rule Require compatible vendor prefixesMissing vendor: -moz for property: transform

File LineSite.css 192, 192, 159, 196, 165, 165,

125, 159, 196, 38, 159, 186,182, 182, 196, 186, 186, 182,165, 38, 192

angular-block-ui.css 83, 88, 83, 88

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 45

Page 48: webstore

angular-block-ui.min.css 5, 5, 5, 5loading-bar.css 104, 92, 104, 93, 96, 101, 93,

101, 93, 97, 96, 101, 100,100, 92, 105, 100, 105, 97,96, 97, 92, 105, 104

loading-bar.min.css 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8

bootstrap-theme.css 297, 391, 228, 264, 465, 240,17, 7, 202, 413

bootstrap-theme.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5bootstrap.css 4270, 2873, 2545

Rule Disallow overqualified elementsDisallow overqualified elements

File LineHelpPage.css 14, 125Site.css 89, 118, 143, 136angular-block-ui.css 17angular-block-ui.min.css 5loading-bar.css 29, 21, 28, 22loading-bar.min.css 8, 8, 8, 8bootstrap-theme.css 410bootstrap-theme.min.css 5bootstrap.css 1371, 1517, 3119, 1390,

5250, 5222, 5208, 3215,3080, 2679, 3170, 3257,3164, 5288, 5266, 3299,4758, 2678, 5294, 3302,1384, 4915, 5244, 3254,3342, 3035, 3167, 3209,5272, 2894, 3074, 3122,5712, 4916, 3212, 1353,3077, 1396, 5203, 1378,5228, 2684, 4593, 3125,4839, 3376, 3260, 1359,2685, 1402, 3305, 1347,1365, 4491

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5

Rule Unused function parameters should be removedRemove the unused function parameter "index".

File LineChart.js 955, 2123Chart.min.js 10

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 46

Page 49: webstore

angular-animate.js 1375, 496angular-animate.min.js 17, 6angular-block-ui.js 152, 156, 189, 158angular-file-upload-shim.js 171, 175angular-file-upload.js 198, 246angular-mocks.js 152, 1699angular-route.js 6, 569angular-route.min.js 6, 11angular-ui-router.js 1124, 1107, 1706, 4043,

3477, 2825, 1088ui-bootstrap-tpls.js 3394, 1552, 28, 3808, 1327,

1354, 197, 1622, 1271, 2533,3205, 3413, 1387

ui-bootstrap.js 3412, 1551, 196, 2532, 1270,1386, 3807, 3393, 3204,1326, 1353, 27, 1621

angular.js 19754, 8327, 8320, 15141,22860, 20687, 10797, 23638,7126, 23203

angular.min.js 221, 96, 131, 224, 153, 159,229, 52

CreateStoreController.js 42, 17, 68CreateUserController.js 24, 26EditStoreController.js 56, 97, 18EditUserController.js 69, 34HomeController.js 4RegisterController.js 5, 143UserStoreController.js 5check-list-model.js 79LoginService.js 62, 44RegionService.js 4, 10, 18, 28, 35RegisterService.js 95, 10, 30, 115, 123, 4

Rule Functions should not have too many linesThis function has 138 lines, which is greater than the 100 lines authorized. Split it intosmaller functions.

File LineChart.js 910, 2326, 1884, 3135, 2764,

12, 2023, 1756, 2885, 1609,2510

angular-animate.js 632, 448, 485, 1587, 1282,1824

angular-block-ui.js 384, 388angular-breadcrumb.js 22, 35angular-chart.js 13, 78angular-file-upload.js 198, 332, 409, 32

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 47

Page 50: webstore

angular-loading-bar.js 35, 178, 167, 33angular-mocks.js 637, 308, 1093, 452, 292angular-resource.js 471, 444, 468, 325angular-route.js 236, 42angular-store.js 3, 67angular-ui-router.js 1229, 738, 1725, 3048, 318,

2144, 384, 1973, 3735, 348,2825

ui-bootstrap-tpls.js 2102, 3260, 1424, 2533,2536, 846, 1010, 3542, 2490,2094, 2435, 1435, 1927,2286, 1191, 713, 426, 2491,3536

ui-bootstrap.js 1434, 1423, 2434, 845, 2093,3535, 2532, 2489, 1009, 712,2101, 2490, 2535, 1190, 425,2285, 3259, 1926, 3541

angular.js 1761, 5431, 11331, 6647,24553, 2139, 10279

Rule "for...in" loops should filter properties before acting on themInsert an if statement at the beginning of this loop to filter items.

File LineChart.js 204Chart.min.js 10angular-animate.js 1327, 1952angular-animate.min.js 14, 25angular-cookies.js 98angular-cookies.min.js 6, 6, 6angular-file-upload.min.js 2, 2, 2angular-google-maps.min.js 6, 8, 9, 10, 10, 7, 8, 10, 10, 8,

6, 10, 8, 5, 6, 5, 7, 8, 8, 8, 6,8, 7, 7, 8, 10, 6, 8, 10, 8, 7,10, 10, 5, 6, 6, 8, 8, 5, 10, 5,8, 10, 8, 7, 7, 9, 7, 5, 7, 11,10, 10, 5, 6, 5, 6, 8, 7

angular-resource.min.js 6angular-ui-router.js 137angular-ui-router.min.js 7, 7, 7, 7angular.js 24642, 14409, 23926, 6988,

2964, 9461, 16844angular.min.js 7, 124, 168, 122, 28, 233, 79,

7, 246, 122, 234, 50, 161, 11,121

Rule Beware of box model size

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 48

Page 51: webstore

Possible box sizing issue

File LineSite.css 109, 110loading-bar.css 75loading-bar.min.css 8bootstrap.css 3740, 2714, 2545, 3763,

2766, 2751, 2442, 2729,2492, 4104, 4340, 4177,6231, 2699, 3414, 1157,1135, 5646, 5653, 4235,6220, 2736

bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5, 5,5, 5, 5, 5, 5, 5, 5, 5, 5, 5

metro-bootstrap-responsive.css 250metro-bootstrap-responsive.min.css 1metro-bootstrap.css 8392, 7156, 2474, 7447,

1133, 8005, 2524, 2370,2632, 6594, 2175, 8375,5306, 4929, 3400, 1158,7169, 4383, 5957, 6459,4896, 7640, 7, 7616, 6006,5871, 2968, 8224, 6506, 60,3809, 6616, 2620, 3858,6668, 7607, 7358, 3727,3035, 6217, 7765, 3692,8511, 1246, 5797, 1822,7710, 7164, 7534, 7735

Rule Named function expressions should not be usedMake this function anonymous by removing its name: 'function() {...}'.

File Lineangular-breadcrumb.js 245, 199angular-chart.js 79angular-file-upload.js 446angular-file-upload.min.js 2angular-mocks.js 141, 772angular-route.js 872angular-ui-router.js 1200, 3525, 1687, 1555,

3048, 3006, 3291, 3351,2936, 1189, 3840, 3394

ui-bootstrap-tpls.js 3168, 2471, 2995, 3206, 337,2980, 2491, 3006, 2536,2737, 2154, 2745, 2189

ui-bootstrap.js 2736, 3005, 2470, 336, 2535,2153, 2490, 2744, 2188,2979, 2994, 3167, 3205

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 49

Page 52: webstore

angular.js 25764, 23405, 12256, 25917,6914, 20582, 14007, 23611,12151, 12204, 6902, 12238,12337, 10213, 22075, 20515,15141, 20380, 13925, 24869,7705, 11457, 12707, 1761,22328, 18182, 8058, 4587,10190, 13985, 25230, 4995,20587, 24553, 8004, 25088,10419, 24169, 12912, 25244,4481, 12868, 13392, 21563,6897, 20450, 25030, 12169,20384, 1454, 14926, 6923,15722, 3290

Rule Disallow selectors that look like regular expressionsDisallow regular expression like selectors

File Linebootstrap.css 212, 2326, 2321, 3728, 2327,

213bootstrap.min.css 5, 5, 5, 5, 5, 5iconFont.min.css 1, 1, 1metro-bootstrap-responsive.css 257, 262, 130, 152, 276, 271,

157, 125metro-bootstrap-responsive.min.css 1, 1, 1, 1, 1, 1, 1, 1metro-bootstrap.css 5136, 3211, 2951, 6709,

3207, 6758, 2155, 1932,7251, 1941, 4145, 3209,1459, 6737, 3204, 6884,6881, 7312, 4143, 4915,2948, 3208, 8342, 6208,2141, 4405, 2168, 6755,5845, 4414, 156, 4197, 5590,3205, 3206, 7298, 2254,2950, 7214, 4198, 1412,7265, 8194, 4144, 1726,2119, 3333, 1928, 2947,1802, 2274, 3332, 6863,3334, 5068, 6835, 1935,2949, 1556, 1555, 1898,2946, 3210, 1417, 4142,1462, 1938, 157

metro-bootstrap.min.css 1

Rule Bitwise operators should not be usedRemove the use of "&" operator.

File Lineangular-chart.js 239, 239, 240, 241, 240angular-chart.min.js 1, 1, 1, 1, 1

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 50

Page 53: webstore

angular-google-maps.min.js 9, 10, 9, 9, 10, 10, 9, 9, 9, 9,9, 9

angular-ui-router.js 88angular-ui-router.min.js 7angular.js 216, 20695, 210, 24488,

20696, 216angular.min.js 159, 231, 159bootstrap.js 1642, 824, 1642bootstrap.min.js 6, 6, 6jquery-2.1.3.js 1331, 705, 599, 927, 705,

1314, 1875, 4533, 4533,3291, 705, 1273, 4533, 926,2557, 705

jquery-2.1.3.min.js 2, 2, 2, 2, 3, 3, 3, 2, 2, 2, 2, 2,2, 2, 2, 2

knockout-3.3.0.debug.js 366, 897knockout-3.3.0.js 15, 29, 29lodash.js 4258, 2636, 4258, 3686,

3554, 3515, 7511, 807, 5743,1957, 3516, 4255, 1956,3518, 3716, 3620, 4280,3553, 4242, 7420, 3692,4248, 2867, 3514

Rule Disallow IDs in selectorsDisallow IDs in selectors

File LineHelpPage.css 7, 125Site.css 136, 46, 100, 93, 89, 125, 61,

73, 52, 126, 143loading-bar.css 75, 29, 67, 33, 9, 22, 10, 19,

26, 28, 27, 21, 20, 51loading-bar.min.css 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8, 8,

8, 8metro-bootstrap-responsive.css 41, 26, 11, 15, 47, 32, 38, 50,

29, 19, 44, 35metro-bootstrap-responsive.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1metro-bootstrap.css 3468, 695, 4363, 3460, 708,

714, 3455, 699, 717, 702,497, 484, 723, 711, 4358,705, 67, 720, 692, 487, 4368

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1

Rule Dead Stores should be removedRemove this useless assignment to local variable "lastRotated"

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 51

Page 54: webstore

File LineChart.js 1558Chart.min.js 10angular-block-ui.min.js 6angular-google-maps.min.js 10, 6, 8, 10, 7, 8, 7, 7, 8, 6, 8,

8, 8, 5, 5, 5, 5, 6, 8, 5, 8, 6, 8,10, 5, 7, 5, 8, 6, 7, 5, 6, 8, 6,5, 10, 9, 7, 7, 8, 8, 8, 7, 8, 8,6, 6, 8, 8, 8, 6, 8, 7, 8, 8, 7, 5,8, 8, 10, 9, 8, 5, 6, 8, 5, 6, 5,8, 7, 8, 8, 8, 7, 6, 7, 5

angular.js 12183, 12251, 25634bootstrap.min.js 6jquery-2.1.3.js 294jquery-2.1.3.min.js 2knockout.validation.min.js 10angular-translate.js 2324angular-translate.min.js 6ui-utils.js 1359ui-utils.min.js 7

Rule Variables and functions should not be redeclaredRename "width" as this name is already used in declaration at line 40.

File LineChart.js 47, 48Chart.min.js 10, 10angular-animate.min.js 24, 23, 13, 27, 24, 23, 20, 11,

27angular-file-upload-shim.js 353, 357angular-file-upload-shim.min.js 2, 2angular-file-upload.js 439angular-file-upload.min.js 2angular-resource.min.js 7angular-route.min.js 6angular.js 16084angular.min.js 188, 79, 72, 72, 72, 169, 144,

144, 230, 109, 72, 28, 72,201, 208, 159, 71, 71, 80,144, 159, 232, 170, 159, 159,66, 132, 107, 72

knockout-3.3.0.debug.js 291, 5041, 1593, 291, 5331knockout-3.3.0.js 112, 42, 25, 76, 100, 27, 76,

111, 96, 112, 61, 60, 42, 20,27, 29, 105, 42

lodash.js 9701

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 52

Page 55: webstore

metro.min.js 130, 147, 58, 119, 131, 19,109, 131, 136, 131, 19, 139,129, 109

Rule Disallow universal selectorDisallow universal selector as key part

File Linebootstrap.css 195, 1078, 1072bootstrap.min.css 5metro-bootstrap.css 1759, 2079, 8302, 2211,

3267, 15, 5085, 8299, 1858,1855, 8013, 8154, 1118,2214, 1674, 5547, 1638, 132,1762, 1686, 1677, 139, 8151,1683, 3272, 2076, 5550

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1, 1, 1

Rule Unused local variables should be removedRemove the declaration of the unused 'getAngleFromPoint' variable.

File LineChart.js 341, 1219, 2301, 383, 506,

253, 1548, 748, 242, 1593,22, 362, 1803, 687, 774, 316,708, 265

angular-animate.js 442, 1715angular-store.js 354angular-ui-router.js 4011, 787, 909ui-bootstrap-tpls.js 145, 457ui-bootstrap.js 1686, 144, 456angular.js 23926, 14260, 49angular.min.js 161CreateStoreController.js 70, 71EditStoreController.js 99, 100knockout-3.3.0.debug.js 796knockout.validation.js 1095, 1056, 1255, 1055,

1094, 1254lodash.js 965, 4404, 12043sammy-0.7.5.js 1108, 1640sammy-0.7.5.min.js 5, 5

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 53

Page 56: webstore

Rule Disallow units for zero valuesDisallow zero values with units

File LineHelpPage.css 33, 73, 73, 33, 52, 73, 82, 53,

33, 82, 82Site.css 109, 110, 110, 109loading-bar.css 100, 104, 108, 96, 92loading-bar.min.css 8, 8, 8, 8, 8metro-bootstrap.css 7137, 4833, 3593, 4833,

7186, 5607, 2149, 1819,6474, 6580, 3359, 8359,2271, 2136, 2364, 3552,5637, 7338, 1915, 8211

Rule Require standard property with vendor prefixNo standard property defined after

File LineSite.css 166, 197, 40, 187, 41, 193,

132, 131, 183, 160, 207, 206loading-bar.css 12loading-bar.min.css 8bootstrap.css 162, 2446, 132, 2593, 11,

166, 10, 5713, 1086bootstrap.min.css 5, 5, 5, 5, 5, 5, 5, 5, 5metro-bootstrap.css 106, 115, 3364, 2979, 92metro-bootstrap.min.css 1, 1, 1, 1, 1

Rule [Functions|Methods|Lambdas] should not have too many parametersFunction has 8 parameters which is greater than 7 authorized.

File Lineangular-animate.js 1282, 485angular-animate.min.js 12, 7angular-file-upload.js 517angular-file-upload.min.js 2angular-google-maps.min.js 6, 7, 7, 8, 6, 6, 5, 6, 6, 7angular-route.js 236angular-route.min.js 9angular-ui-router.js 2825ui-bootstrap-tpls.js 1010ui-bootstrap-tpls.min.js 8ui-bootstrap.js 1009ui-bootstrap.min.js 8

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 54

Page 57: webstore

angular.js 6647, 9785, 7318, 20116,7908, 22818

angular.min.js 211, 64, 85, 220, 49, 55EditUserController.js 5LoginController.js 3RegisterController.js 5UserStoreController.js 5lodash.js 3513, 3685

Rule Nested blocks of code should not be left emptyEither remove or fill this block of code.

File Lineangular-file-upload-shim.min.js 2angular-google-maps.min.js 10ui-bootstrap-tpls.js 1254ui-bootstrap.js 1253angular.js 11647, 1086angular.min.js 14, 49, 54, 14, 40, 102jquery-2.1.3.js 8517, 2954, 3739, 5324,

4072, 1417, 739, 839jquery-2.1.3.min.js 2, 3, 2, 3, 4, 2knockout-3.3.0.debug.js 476, 102knockout-3.3.0.js 18, 113lodash.js 784, 625, 2816, 408, 768,

424, 640jquery.ui.widget.js 16modernizr-2.8.3.js 765, 743

Rule Array and Object constructors should not be usedUse a literal instead of the Array constructor.

File LineChart.js 507Chart.min.js 10ui-bootstrap-tpls.js 1209, 1239, 1310, 2905,

1371ui-bootstrap-tpls.min.js 8, 8, 8, 9, 8ui-bootstrap.js 2904, 1208, 1370, 1238,

1309ui-bootstrap.min.js 8, 8, 8, 9, 8angular.js 7078, 13958, 25883, 13957,

24613, 10193, 14184jquery-2.1.3.js 3343, 3344, 3345

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 55

Page 58: webstore

jquery-2.1.3.min.js 2, 2, 2lodash.js 1823

Rule Require properties appropriate for displayUnnecessary property with display

File Linebootstrap.css 4026, 3703, 2321, 2326,

3961bootstrap.min.css 5, 5, 5, 5, 5metro-bootstrap.css 3481, 5656, 3739, 8117,

5513, 1998, 5887, 3608,1555, 2279, 3460, 4990,7058

metro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,1

Rule Functions should not be defined inside loopsDefine this function outside of a loop.

File LineChart.min.js 10angular-google-maps.min.js 9, 5angular-mocks.js 545angular.js 7181, 24681, 12169, 24628,

3083angular.min.js 234, 169, 193, 234, 80, 53CreateUserController.js 64EditUserController.js 83RegisterController.js 219jquery-2.1.3.min.js 2, 2, 2knockout-3.3.0.debug.js 5277knockout-3.3.0.js 19, 38, 111, 19lodash.js 11239metro.min.js 80sammy-0.7.5.js 1705sammy-0.7.5.min.js 5angular-translate.min.js 6, 6ui-utils.min.js 7, 7, 7

Rule "switch" statements should end with a "default" clauseAvoid switch statement without a "default" clause.

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 56

Page 59: webstore

File LineChart.js 1347, 1324Chart.min.js 10, 10angular-google-maps.min.js 6, 9angular.js 7673, 7161angular.min.js 52, 57RegisterController.js 95knockout-3.3.0.debug.js 5287, 3071, 2029, 3395knockout-3.3.0.js 111, 69, 49, 73knockout.validation.js 155knockout.validation.min.js 10lodash.js 2940, 4082, 4024, 3792,

8118metro.min.js 51ui-utils.js 1053ui-utils.min.js 7

Rule Collapsible "if" statements should be mergedMerge this if statement with the nested one.

File LineChart.js 322, 1830angular-animate.js 591angular-chart.js 100angular-route.js 501angular-ui-router.js 3112angular.js 910, 11403, 7575, 7187HomeController.js 12jquery-2.1.3.js 2108, 4160, 4360, 4432,

2169, 2508, 4362jquery.signalR-2.2.0.js 2390, 1888knockout-3.3.0.debug.js 666knockout.validation.js 545respond.js 124respond.matchmedia.addListener.js 173angular-translate.js 1862ui-utils.js 1382

Rule Sections of code should not be "commented out"Remove this commented out code.

File LineBundleConfig.cs 24

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 57

Page 60: webstore

Startup.Auth.cs 87, 83, 90, 93, 79HelpPageConfig.cs 76, 64, 68, 72, 43, 45, 37, 80HelpPageConfigurationExtensions.cs 287, 275, 277XmlDocumentationProvider.cs 142AccountController.cs 226, 174StoreHub.cs 42, 36, 29

Rule Files should not have too many linesFile "Chart.js" has 3.477 lines, which is greater than 1.000 authorized. Split it into smallerfiles.

File LineChart.js N/Aangular-animate.js N/Aangular-mocks.js N/Aangular-ui-router.js N/Aui-bootstrap-tpls.js N/Aui-bootstrap.js N/Aangular.js N/APayPhoneErrors.js N/Abootstrap.js N/Ajquery-2.1.3.intellisense.js N/Ajquery-2.1.3.js N/Ajquery.signalR-2.2.0.js N/Aknockout-3.3.0.debug.js N/Aknockout.validation.js N/Alodash.js N/Amodernizr-2.8.3.js N/Asammy-0.7.5.js N/Aangular-translate.js N/Aui-utils.js N/A

Rule Loops should not contain more than a single "break" or "continue"statement

Reduce the total number of "break" and "continue" statements in this loop to use one atmost.

File Lineangular-file-upload.js 421angular-file-upload.min.js 2angular-google-maps.min.js 10, 10, 10angular-ui-router.js 111, 2249jquery-2.1.3.js 2501

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 58

Page 61: webstore

jquery-2.1.3.min.js 2knockout-3.3.0.debug.js 2217knockout-3.3.0.js 52knockout.validation.js 661lodash.js 1170, 1176ui-utils.js 2199

Rule Bulletproof font faceFirst web font has missing query string or it is not eot

File Linebootstrap.css 267bootstrap.min.css 5iconFont.min.css 1metro-bootstrap.css 662, 668, 656, 674, 8419metro-bootstrap.min.css 1, 1, 1, 1, 1

Rule Disallow duplicate background imagesDisallow duplicate background images

File Linemetro-bootstrap.min.css 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1

Rule Two branches in the same conditional structure should not have exactlythe same implementation

Either merge this branch with the identical one on line "1961" or change one of theimplementations.

File LineChart.js 1963angular-google-maps.min.js 9angular.js 4121, 12329, 4475, 11915,

4472angular.min.js 187jquery.signalR-2.2.0.js 361

Rule Constructor functions should not be called purely for side-effectsReplace by a standard call to the function.

File LineChart.js 1027, 999

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 59

Page 62: webstore

2.5. Most violated files by level with priority up to info

BLOCKER violations

CRITICAL violations

Chart.min.js 10, 10angular.js 956angular.min.js 162knockout-3.3.0.debug.js 5042, 5037

Rule Variables should always be declared with "var"Add the "var" keyword to this declaration of "FormData".

File Lineangular-file-upload-shim.js 250, 267angular-file-upload-shim.min.js 2, 2metro.min.js 44, 75, 19

File ViolationsStoreRoutes.js 18jquery-2.1.3.intellisense.js 6RegisterService.js 4StoreService.js 2UserStoreService.js 2LoginService.js 2RegisterController.js 1

File Violationslodash.js 21angular.min.js 4jquery-2.1.3.min.js 3angular.js 3angular-google-maps.min.js 2angular-resource.js 2angular-resource.min.js 2knockout-3.3.0.debug.js 2knockout-3.3.0.js 2

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 60

Page 63: webstore

MAJOR violations

MINOR violations

File Violationsangular-google-maps.min.js 3,659metro-bootstrap.css 2,241metro-bootstrap.min.css 2,233angular.min.js 1,870jquery-2.1.3.min.js 1,779angular.js 760knockout-3.3.0.js 740metro.min.js 729ui-utils.min.js 547bootstrap.css 532bootstrap.min.css 530knockout-3.3.0.debug.js 444angular-ui-router.min.js 419Chart.min.js 417ui-bootstrap.min.js 399ui-bootstrap-tpls.min.js 399bootstrap.min.js 392lodash.js 357jquery.signalR-2.2.0.min.js 347angular-translate.min.js 336jquery-2.1.3.js 309bootstrap.js 246sammy-0.7.5.js 236knockout.validation.min.js 230angular-animate.min.js 215angular-ui-router.js 196Chart.js 138angular-file-upload.min.js 136metro-bootstrap-responsive.css 126metro-bootstrap-responsive.min.css 126angular-file-upload-shim.min.js 103bootstrap-theme.css 84bootstrap-theme.min.css 84ui-bootstrap.js 80

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 61

Page 64: webstore

INFO violations

2.6. Additional information

File ViolationsNo violations

File ViolationsNo violations

PayPhone WebStore1.0

07/05/2015 01:26:54 PM 62


Recommended